Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inverted flag to propagate preloaded StrawDigiMCs #1293

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

edcallaghan
Copy link
Contributor

This PR fixes a bug present in #1245, which introduced the overlay of simulated tracker digis onto a collection of preexisting digis, which may or may not have been produced by earlier simulation. Whether or not the preexisting digis were produced by simulation is maintained by a field in StrawDigiMC, which is set in the StrawDigisFromStrawGasSteps module, following fcl configuration. The original implementation used the flag in an inverted fashion, marking presimulated digis as non-simulated, and vice versa. This does not effect any tagged datasets.

@FNALbuild
Copy link
Collaborator

Hi @edcallaghan,
You have proposed changes to files in these packages:

  • TrackerMC

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 629ddbb: build (Build queue has 7 jobs)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 629ddbb.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 629ddbb at 684bac4
build (prof) Log file. Build time: 04 min 10 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 🔶 TODO (0) FIXME (7) in 1 files
clang-tidy 🔶 0 errors 407 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 629ddbb after being merged into the base branch at 684bac4.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@kutschke kutschke self-requested a review June 25, 2024 17:19
@kutschke kutschke self-assigned this Jun 25, 2024
Copy link
Collaborator

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straightfoward.

@kutschke kutschke merged commit 825dc59 into Mu2e:main Jun 25, 2024
14 checks passed
@edcallaghan
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants