Update VesselState.cs #1873
Merged
Update VesselState.cs #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug reported MuMech#1860 where RCS keeps turning on when unwanted for non-Real Fuels users and requires turning off AutoRCSUllaging. This may be enough to fix it but this could use other sanity checks elsewhere. Also, RCS ullaging should either * Check for Core.Attitude.RCS_auto = true or else don't enable RCS! * Put in code to turn RCS back off when ullaging is completed.
|
sorry been busy and i didn't check to see how easy this one was. |
|
I think i'd be okay with checking RCS_auto but does it persist? And for RF it'd be nice to force it to true rather than false somehow. |
Pretty sure it does not persist. Not last time I checked and I don't think that ever changed. |
|
Yeah for RO/RF that should really persist, probably should persist anyway. Because really in RO/RF with PVG coasts I want to make it pretty difficult to disable RCS, rather than having it easy to forget to enable it all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug reported #1860 where RCS keeps turning on when unwanted for non-Real Fuels users and requires turning off AutoRCSUllaging. This may be enough to fix it but this could use other sanity checks elsewhere. Also, RCS ullaging should either