Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.menu-item li height made scrollbar #17

Closed
jbts6 opened this issue Jul 10, 2020 · 2 comments
Closed

.menu-item li height made scrollbar #17

jbts6 opened this issue Jul 10, 2020 · 2 comments
Assignees
@MuYunyun
Labels
bug Something isn't working

Comments

@jbts6
Copy link

jbts6 commented Jul 10, 2020

image
image

这个height属性导致有滚动条出现，去掉这个后，滚动条消失，发现高度变成了40.84。
继续深入发现是
image
这里的vertical-align: middle;导致的
@MuYunyun MuYunyun added the bug Something isn't working label Jul 12, 2020
@MuYunyun
Copy link
Owner

MuYunyun commented Jul 12, 2020 •
edited
Loading

感谢指出。

这里 vertical-align: middle 的作用是让 icon 和文字水平对齐, 因此也不能去掉。可以在 submenu 或者 menu 处加个 overflow: hidden

image

下个版本会修复。

MuYunyun added a commit that referenced this issue Jul 12, 2020
@MuYunyun
fix: #17
a0a1c8d
@MuYunyun
Copy link
Owner

@fh345392977 0.1.20 version 已修复

@MuYunyun MuYunyun self-assigned this Jul 13, 2020
MuYunyun added a commit that referenced this issue Dec 25, 2023
@MuYunyun
fix: #17
0483584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MuYunyun MuYunyun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbts6 @MuYunyun