Move the icon of .desktop file so it can be themed #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat. Maybe I should apply this to the debian package and then we don't have to do it here. |
|
That'd probably be ideal, I thought patching the PKGBUILD would be the simplest way 😅; although I guess the PKGBUILD would still need to be adjusted after the .deb update. Also, since I made this PR I realized the |
|
Merging MultiMC/Launcher#4971 should apply this change to the Debian package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MultiMC icon is placed in
/opt/multimc/, and the.desktopfile points to it directly.Because of that icon themes are unable to theme MMC, making it stand out in the application launcher.
This PR moves the icon over to
/usr/share/icons/hicolor/scalable/apps//usr/share/pixmaps/and a patch is applied to the.desktopfile to point tomultimcicon. This way, if a user wishes to use a theme including an icon for MMC, the theme will be picked up; otherwise it'll fall back to the bundled icon.