Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add QRCode feature #9

Merged
merged 7 commits into from
Aug 30, 2024
Merged

feat: add QRCode feature #9

merged 7 commits into from
Aug 30, 2024

Conversation

xfqz86
Copy link
Contributor

@xfqz86 xfqz86 commented Aug 29, 2024

No description provided.

MultiMote
MultiMote requested changes Aug 29, 2024
View reviewed changes
Copy link
Owner

@MultiMote MultiMote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you so much for your contribution!
Please make a few changes so I can accept your pull request.

niimblue/src/lib/ImageEditor.svelte Outdated Show resolved Hide resolved
niimblue/src/lib/ImageEditor.svelte Outdated Show resolved Hide resolved
niimblue/src/lib/QRCodeParamsControls.svelte Outdated Show resolved Hide resolved
niimblue/src/lib/QRCodeParamsControls.svelte Outdated Show resolved Hide resolved
niimblue/src/lib/QRCodeParamsControls.svelte Outdated Show resolved Hide resolved
niimblue/src/fabric-object/qrcode.class.ts Outdated Show resolved Hide resolved
@MultiMote
Copy link
Owner

Also, saving then loading labels not working (Cannot read properties of undefined (reading 'fromObject')).

@xfqz86
Copy link
Contributor Author

xfqz86 commented Aug 30, 2024

Also, saving then loading labels not working (Cannot read properties of undefined (reading 'fromObject')).

607c3d3 fixed

@MultiMote MultiMote merged commit 42c1109 into MultiMote:draft Aug 30, 2024
@MultiMote MultiMote mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MultiMote MultiMote MultiMote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xfqz86 @MultiMote