Odoo 160 #13
Open
Odoo 160 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split 'payment_multisafepay_official' into 'payment_multisafepay' (core) and 'payment_multisafepay_enhaced' (features). - Update webhook controller to process request data as text (UTF-8) compatible with SDK fix (ensure_ascii=False). - Remove deprecated official module files.
- Restore accidental deletion of code in payment_provider.py and fix return placement. - Correct translation placeholders to use named arguments instead of positionals. - Add timeout to requests.get call in utils.py. - Remove print statement in tests. - Merge duplicate disable keys in .pylintrc-mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor and rebranding of the MultiSafepay payment integration module, along with several configuration and workflow improvements. The primary focus is on renaming the module from
payment_multisafepay_officialtopayment_multisafepay, adding a manifest, introducing a constants file, updating workflow and linting configurations, and adding German translations.Module Renaming and Manifest Addition:
payment_multisafepay_officialtopayment_multisafepaythroughout the codebase, including file and directory names, internal references, and asset paths, to standardize naming and improve maintainability. [1] [2]payment_multisafepay/__manifest__.pyhas been added, specifying metadata, dependencies, hooks, and data files for the module.New Features and Improvements:
payment_multisafepay/const.pyhas been introduced, centralizing payment method prefixes, supported currencies, status mappings, and lists of special payment methods.payment_multisafepay/i18n/de_DE.poto support localization for German-speaking users.Configuration and Workflow Updates:
.github/workflows/release.ymlhas been updated to use the new module name and correct script paths, ensuring the release process aligns with the new structure. [1] [2].pylintrc-mandatorynow disables additional checks related to manifest author and readme requirements, and enables a more tailored set of pylint rules. [1] [2] [3].ruff.tomlnow ignores complexity and exception chaining warnings, and disables the line length check for more flexible code formatting.Summary of Most Important Changes:
Module Refactor and Rebranding
payment_multisafepay_officialtopayment_multisafepayacross all files, references, and asset paths for consistency and clarity. [1] [2]__manifest__.pyto define module metadata, dependencies, and data files.New Features and Localization
const.pyto centralize constants such as supported currencies and payment status mappings.i18n/de_DE.pofor improved localization.CI/CD and Linting Configuration
.pylintrc-mandatoryand.ruff.tomlfor more relevant and flexible code quality checks. [1] [2] [3] [4]