Skip to content

@joe10832 <issue_title>@Copilot-setup-steps>/@copilot <issue_title>Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.</issue_title> #328

@joe10832

Description

@joe10832

@joe10832 <issue_title>@Copilot-setup-steps>/@copilot <issue_title>Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.</issue_title>
<issue_description>@Copilot-setup-steps>/@copilot <issue_title>

OTK-30 Implement Coinbase Notification Type Detection Logic, Grant Spend Permission and Sign In With Hardcoded Passkey Credential

</issue_title>
<issue_description>
OTK-30 Implement Coinbase Notification Type Detection Logic, Grant Spend Permission and Sign In Wi.github/workflows/e2e-tests.yml/@copilotcopilot/fix-e218a231-b88f-4907-938c-9b15ffd4815adiff --git a/README.md b/README.md
--- a/README.md
+++ b/README.md
@@ -17,1 +17,1 @@
-Guidelines on how to contribute to this project.https://stackblitz.com/~/github.com/MunyayLLC/https-github.com-joe10832-onchaintestkit/pull/286https://stackblitz.com/~/github.com/MunyayLLC/https-github.com-joe10832-onchaintestkit/pull/288https://stackblitz.com/~/github.com/MunyayLLC/https-github.com-joe10832-onchaintestkit/pull/286?file=package.json
+Guidelines on how to contribute to this project.https://stackblitz.com/~/github.com/MunyayLLC/https-github.com-joe10832-onchaintestkit/pull/286https://stackblitz.com/~/github.com/MunyayLLC/https-github.com-joe10832-onchaintestkit/pull/288https://stackblitz.com/~/github.com/MunyayLLC/https-github.com-joe10832-onchaintestkit/pull/286?file=package.json
@@ -18,1 +18,1 @@
-- **Write and maintain documentation (README.md, `CONTRIBUTING.md # Enterprise-Ready Software Engineering Project
+

  • **Write and maintain documentation (README.md, `CONTRIBUTING.md # Enterprise-Ready Software Engineering Project
    @@ -45,1 +45,1 @@
    -### General Guidelines
    +### General Guidelines

@@ -46,1 +46,1 @@
-- Use language-specific conventions for Python, Java, and C++.
+

  • Use language-specific conventions for Python, Java, and C++.
    @@ -50,1 +50,1 @@
    -### Python
    +### Python

@@ -51,1 +51,1 @@
-- Follow PEP 8 for coding standards.
+

  • Follow PEP 8 for coding standards.
    @@ -55,1 +55,1 @@
    -### Java
    +### Java

@@ -56,1 +56,1 @@
-- Adhere to Oracle's Java Code Conventions.
+

@@ -61,1 +61,1 @@
-- Follow Google's C++ Style Guide.
+

  • Follow Google's C++ Style Guide.
    diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
    --- a/CONTRIBUTING.md
    +++ b/CONTRIBUTING.md
    @@ -20,1 +20,1 @@
    • Try to keep line length in code blocks to 80 characters or fewer.
    • Try to keep line length in code blocks to 80 characters or fewer.
      @@ -21,1 +21,1 @@
    • Otherwise, the text will overflow and look odd.
    • Otherwise, the text will overflow and look odd.
      @@ -22,1 +22,1 @@
    • This and other potential pitfalls to format the content consistently are
    • This and other potential pitfalls to format the content consistently are
      @@ -25,1 +25,1 @@
    • Try to use as few words as possible.
    • Try to use as few words as possible.
      @@ -26,1 +26,1 @@
    • Code examples are preferred over exposition in all cases.
    • Code examples are preferred over exposition in all cases.
      @@ -28,1 +28,1 @@
    • We welcome newcomers, but the target audience for this site is programmers
    • We welcome newcomers, but the target audience for this site is programmers
      @@ -30,1 +30,1 @@
    • Try to avoid explaining basic concepts except for those specific to the
    • Try to avoid explaining basic concepts except for those specific to the
      @@ -32,1 +32,1 @@
    • Keep articles succinct and scannable. We all know how to use Google here.
    • Keep articles succinct and scannable. We all know how to use Google here.
      @@ -55,1 +55,1 @@
      -* translators: A list of [translator, URL] lists to credit, URL is optional
  • translators: A list of [translator, URL] lists to credit, URL is optional
    @@ -76,1 +76,1 @@
    -#### Writing Tests
    +#### Writing Tests

@@ -77,1 +77,1 @@
-- Place tests in the tests/ directory
+

  • Place tests in the tests/ directory
    @@ -82,1 +82,1 @@
    -#### Test Requirements
    +#### Test Requirements

@@ -83,1 +83,1 @@
-- All new features must have corresponding tests
+

  • All new features must have corresponding tests
    @@ -90,1 +90,1 @@
    -#### TypeScript Guidelines
    +#### TypeScript Guidelines

@@ -91,1 +91,1 @@
-- Use strict TypeScript settings
+

  • Use strict TypeScript settings
    @@ -96,1 +96,1 @@
    -#### Formatting and Linting
    +#### Formatting and Linting

@@ -97,1 +97,1 @@
-- Use Biome for formatting and linting
+

  • Use Biome for formatting and linting
    @@ -105,1 +105,1 @@
    -- feat: for new features
  • feat: for new features
    @@ -234,1 +234,1 @@
    -### API Documentation
    +### API Documentation

@@ -235,1 +235,1 @@
-- Update inline JSDoc comments
+

  • Update inline JSDoc comments
    @@ -240,1 +240,1 @@
    -### README Updates
    +### README Updates

@@ -241,1 +241,1 @@
-- Add new features to the feature list
+

  • Add new features to the feature list
    @@ -246,1 +246,1 @@
    -### Example Updates
    +### Example Updates

@@ -247,1 +247,1 @@
-- Add examples for new features
+

  • Add examples for new features
    @@ -296,1 +296,1 @@
    -- Use specific block numbers for reproducibility
  • Use specific block numbers for reproducibility
    @@ -303,1 +303,1 @@
    -### Version Management
    +### Version Management

@@ -304,1 +304,1 @@
-- Follow semantic versioning (semver)
+

  • Follow semantic versioning (semver)
    @@ -309,1 +309,1 @@
    -### Breaking Changes
    +### Breaking Changes

@@ -310,1 +310,1 @@
-- Document breaking changes thoroughly
+

  • Document breaking changes thoroughly
    @@ -317,1 +317,1 @@
    -### Resources
    +### Resources

@@ -318,1 +318,1 @@
-- Check existing documentation
+

  • Check existing documentation
    @@ -323,1 +323,1 @@
    -### Communication
    +### Communication

@@ -324,1 +324,1 @@
-- Open GitHub issues for bugs and feature requests
+

  • Open GitHub issues for bugs and feature requestsOn FUNDING.yml, Pull@joe10832 <issue_title>[BUG] Coinbase Notification Type Detection, Spend Permission Grant, and Passkey Sign-In Failure</issue_title>
    <issue_description>## Bug Description
    Coinbase Notification Type Detection Logic, Spend Permission Grant, and Hardcoded Passkey Credential sign-in are not functioning as expected in Onchain Test Kit (OTK-30).

Steps to Reproduce
Prepare Onchain Test Kit and configure for Coinbase Wallet usage
Initiate a workflow that triggers notification type detection
Attempt to grant spend permission using hardcoded passkey
Try to sign in with hardcoded passkey credential
Expected Behavior
Notification type should be detected correctly, spend permission should be granted, and sign in with hardcoded passkey should succeed without errors.

Actual Behavior
Notification type is not detected; spend permission cannot be granted; sign in with hardcoded passkey credential fails. Observed error during workflow execution.

Environment Information
Onchain Test Kit Version: [please supply]
Node.js Version: [please supply]
Operating System: [please supply]
Browser: [please supply]
Wallet: Coinbase Wallet
Configuration Used
// Paste your configuration code here
// Example:
const config = configure()
.withCoinbaseWallet()
// ... other configuration for notification type and passkey
.build();
Error Logs
Error encountered during notification detection and passkey sign-in (see linked PR review).
Originally posted by @joe10832 in #197 (review)
Code Sample
import { createOnchainTest, configure } from '@coinbase/onchaintestkit';

const test = createOnchainTest(/* your config */);

test('coinbase notification test', async ({ page, coinbase }) => {
// Steps that cause the bug
});
Screenshots
N/A

Additional Context
Issue discovered while implementing OTK-30. Test failure relates to Coinbase-specific logic for notification, spend permission, and passkey credential sign-in.

Possible Solution
Review and correct the Coinbase notification detection logic, permission grant flow, and passkey credential handling in OTK.

Checklist
I have searched for existing issues that describe this bug
I have included all the required environment information
I have provided a minimal code example that reproduces the issue
I have included relevant error messages and logs
</issue_description>
<agent_instructions>import { createOnchainTest, configure } from '@coinbase/onchaintestkit';

const test = createOnchainTest(/* your config */);

test('coinbase notification test', async ({ page, coinbase }) => {
// Steps that cause the bug
});</agent_instructions>

Originally posted by @joe10832 in #326 (comment)

Sub-issues

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions