Skip to content

Fix home directory check in shell scripts to handle tilde (~) input #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joe10832 merged 3 commits into from
Sep 24, 2025
Merged

Fix home directory check in shell scripts to handle tilde (~) input #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8721757
Initial plan
Copilot Sep 24, 2025
fdc2013
Add tilde (~) check to shell script security validation
Copilot Sep 24, 2025
4de35eb
Clean up test artifacts and update .gitignore
Copilot Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,7 @@ yarn-error.log*

example/smart-contracts/lib/
example/smart-contracts/out/
example/smart-contracts/cache/
example/smart-contracts/cache/

# Extension downloads and extractions
e2e/extensions/
2 changes: 1 addition & 1 deletion src/cli/prepare-coinbase.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ print_info "Target directory: $TARGET_DIR"

# Security check: Prevent dangerous directory operations
# Fixed: Use $HOME instead of "~" for proper home directory comparison
if [[ -z "$TARGET_DIR" || "$TARGET_DIR" == "/" || "$TARGET_DIR" == "$HOME" || "$TARGET_DIR" == "." || "$TARGET_DIR" == ".." ]]; then
if [[ -z "$TARGET_DIR" || "$TARGET_DIR" == "/" || "$TARGET_DIR" == "~" || "$TARGET_DIR" == "$HOME" || "$TARGET_DIR" == "." || "$TARGET_DIR" == ".." ]]; then
print_error "Invalid or dangerous target directory: $TARGET_DIR"
print_error "Please specify a safe target directory for Coinbase Wallet extension"
exit 1
Expand Down
2 changes: 1 addition & 1 deletion src/cli/prepare-metamask.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ print_info "Target directory: $TARGET_DIR"

# Security check: Prevent dangerous directory operations
# Fixed: Use $HOME instead of "~" for proper home directory comparison
if [[ -z "$TARGET_DIR" || "$TARGET_DIR" == "/" || "$TARGET_DIR" == "$HOME" || "$TARGET_DIR" == "." || "$TARGET_DIR" == ".." ]]; then
if [[ -z "$TARGET_DIR" || "$TARGET_DIR" == "/" || "$TARGET_DIR" == "~" || "$TARGET_DIR" == "$HOME" || "$TARGET_DIR" == "." || "$TARGET_DIR" == ".." ]]; then
print_error "Invalid or dangerous target directory: $TARGET_DIR"
print_error "Please specify a safe target directory for MetaMask extension"
exit 1
Expand Down
2 changes: 1 addition & 1 deletion src/cli/prepare-phantom.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ print_info "Target directory: $TARGET_DIR"

# Security check: Prevent dangerous directory operations
# Fixed: Use $HOME instead of "~" for proper home directory comparison
if [[ -z "$TARGET_DIR" || "$TARGET_DIR" == "/" || "$TARGET_DIR" == "$HOME" || "$TARGET_DIR" == "." || "$TARGET_DIR" == ".." ]]; then
if [[ -z "$TARGET_DIR" || "$TARGET_DIR" == "/" || "$TARGET_DIR" == "~" || "$TARGET_DIR" == "$HOME" || "$TARGET_DIR" == "." || "$TARGET_DIR" == ".." ]]; then
print_error "Invalid or dangerous target directory: $TARGET_DIR"
print_error "Please specify a safe target directory for Phantom Wallet extension"
exit 1
Expand Down