Conversation
Co-authored-by: joe10832 <103850533+joe10832@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] ✨copilot-setup-steps @copilot /.github/copilot-instructions.md
/.github/instructions/**/*.instructions.md
**/AGENTS.md
/CLAUDE.md
/GEMINI.md
✨ Configure comprehensive AI coding agent instructions for repository
Sep 25, 2025
joe10832
changed the title
Contributor
There was a problem hiding this comment.
.github/instructions/wallet-integration.instructions.md## Pull Request Overview copilot-setup-steps
This PR implements comprehensive GitHub Copilot setup and AI coding agent instructions for the Onchain Test Kit repository, providing specialized guidance for different AI agents working on blockchain testing scenarios.
Key changes include:
- Creation of agent-specific instruction files (CLAUDE.md, GEMINI.md, AGENTS.md) with tailored guidance for each AI's strengths
- Addition of detailed development workflow instructions covering TypeScript, Playwright, and blockchain testing patterns
- Implementation of comprehensive testing strategies including fork mode, wallet automation, and cross-wallet compatibility
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| GEMINI.md | Gemini-specific instructions focused on rapid prototyping, developer experience, and performance optimization |
| CLAUDE.md | Claude-specific instructions emphasizing analytical problem solving and comprehensive blockchain testing scenarios |
| AGENTS.md | General AI coding agent instructions covering project overview and architecture principles |
| .github/instructions/wallet-integration.instructions.md | Specialized guidance for wallet implementations covering MetaMask, Coinbase, and Phantom integrations |
| .github/instructions/testing.instructions.md | Comprehensive testing strategies including fork mode and wallet automation patterns |
| .github/instructions/development.instructions.md | Development environment setup, code quality standards, and workflow guidelines |
Comments suppressed due to low confidence (1)
CLAUDE.md:1
- Same security issue as in GEMINI.md - the hardcoded password 'PASSWORD' should be replaced with an environment variable or documented as a placeholder that needs to be replaced with a secure value.
# Claude AI Instructions for Onchain Test Kit
| .withMetaMask() | ||
| .withSeedPhrase({ | ||
| seedPhrase: process.env.E2E_TEST_SEED_PHRASE!, | ||
| password: 'PASSWORD', |
There was a problem hiding this comment.
The hardcoded password 'PASSWORD' in the code example poses a security risk and doesn't follow best practices. Consider using an environment variable like process.env.WALLET_PASSWORD or documenting that this should be replaced with a secure password in actual usage.
Suggested change
| password: 'PASSWORD', | |
| password: process.env.WALLET_PASSWORD!, |
Comment on lines
+100
to
+101
| seedPhrase: 'test seed phrase', | ||
| password: 'password' |
There was a problem hiding this comment.
The hardcoded credentials 'test seed phrase' and 'password' should use environment variables or be clearly marked as examples that must be replaced with secure values in actual usage.
Suggested change
| seedPhrase: 'test seed phrase', | |
| password: 'password' | |
| // Use environment variables for credentials in real tests | |
| seedPhrase: process.env.E2E_TEST_SEED_PHRASE!, | |
| password: process.env.E2E_TEST_PASSWORD! |
Comment on lines
+98
to
+118
| 1. Create wallet directory: `src/wallets/NewWallet/` | ||
| 2. Implement wallet class extending BaseWallet | ||
| 3. Create Playwright fixtures | ||
| 4. Add CLI preparation scripts | ||
| 5. Update configuration builder | ||
| 6. Add comprehensive tests | ||
| 7. Update documentation | ||
|
|
||
| ### Adding New Wallet Actions | ||
| 1. Define action type in base interfaces | ||
| 2. Implement in all wallet classes | ||
| 3. Add parameter validation | ||
| 4. Create comprehensive tests | ||
| 5. Update type definitions | ||
| 6. Document usage examples | ||
|
|
||
| ### Configuration Changes | ||
| 1. Maintain backward compatibility | ||
| 2. Add proper validation | ||
| 3. Update type definitions | ||
| 4. Provide migration guides if breaking |
There was a problem hiding this comment.
[nitpick] This numbered list format is inconsistent with the bullet point style used elsewhere in the document. For visual consistency, consider using bullet points (-) instead of numbers.
Suggested change
| 1. Create wallet directory: `src/wallets/NewWallet/` | |
| 2. Implement wallet class extending BaseWallet | |
| 3. Create Playwright fixtures | |
| 4. Add CLI preparation scripts | |
| 5. Update configuration builder | |
| 6. Add comprehensive tests | |
| 7. Update documentation | |
| ### Adding New Wallet Actions | |
| 1. Define action type in base interfaces | |
| 2. Implement in all wallet classes | |
| 3. Add parameter validation | |
| 4. Create comprehensive tests | |
| 5. Update type definitions | |
| 6. Document usage examples | |
| ### Configuration Changes | |
| 1. Maintain backward compatibility | |
| 2. Add proper validation | |
| 3. Update type definitions | |
| 4. Provide migration guides if breaking | |
| - Create wallet directory: `src/wallets/NewWallet/` | |
| - Implement wallet class extending BaseWallet | |
| - Create Playwright fixtures | |
| - Add CLI preparation scripts | |
| - Update configuration builder | |
| - Add comprehensive tests | |
| - Update documentation | |
| ### Adding New Wallet Actions | |
| - Define action type in base interfaces | |
| - Implement in all wallet classes | |
| - Add parameter validation | |
| - Create comprehensive tests | |
| - Update type definitions | |
| - Document usage examples | |
| ### Configuration Changes | |
| - Maintain backward compatibility | |
| - Add proper validation | |
| - Update type definitions | |
| - Provide migration guides if breaking |
This was referenced Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive GitHub Copilot setup and AI coding agent instructions for the Onchain Test Kit repository, following the best practices for AI-assisted development workflows.
What's Changed
Added specialized instruction files for different AI coding agents to provide contextual guidance when working on the Onchain Test Kit project:
AGENTS.md- General AI coding agent instructions covering project overview, architecture principles, and common development tasksCLAUDE.md- Claude-specific instructions optimized for analytical problem solving and comprehensive blockchain testing scenariosGEMINI.md- Gemini-specific instructions focused on rapid prototyping, developer experience, and performance optimization.github/instructions/development.instructions.md- Detailed development environment setup, code quality standards, and workflow guidelines.github/instructions/testing.instructions.md- Comprehensive testing strategies including fork mode, wallet automation, and cross-wallet compatibility patterns.github/instructions/wallet-integration.instructions.md- Specialized guidance for wallet implementations, covering MetaMask, Coinbase Wallet, and Phantom integrationsKey Features
Blockchain Testing Expertise: Each instruction file provides detailed guidance on the unique aspects of blockchain DApp testing, including:
TypeScript & Playwright Best Practices: All instructions emphasize the project's core technologies:
Agent-Specific Optimizations:
Content Structure
Each instruction file maintains consistency while providing specialized guidance:
The instructions build upon the existing comprehensive
.github/copilot-instructions.mdfile, providing over 1,880 lines of additional specialized guidance tailored for different AI coding agents working on blockchain testing scenarios.This setup enables AI agents to understand the unique requirements of blockchain DApp testing, wallet automation complexities, and the project's focus on reliability and type safety in end-to-end testing workflows.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.