Validates email address by sending a confirmation email to users #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping develop branch upto date with master.
The buttons were disabled on 'Create Group' and 'Update Group'. Also the error message was changed to 'Group name <group_name> already exists!' fixes Murali-group#323
Disable buttons on submit and give proper error message.
…ph Information" tab. Refers Murali-group#277
Added the name of the groups with which a graph is shared to the "Graph Information" tab.
README.md: Added GraphSpace documentation link
…gistration, a confirmation email with activation link is sent to the email address and when the user clicks the link, the email address is verified and the account gets activated. fixes Murali-group#360
lohani2280
force-pushed
the
send_email_confirmation
branch
from
c138e77 to
aaa91e9
Compare
lohani2280
changed the title
|
@adbharadwaj, @tmmurali Sir, |
|
@lohani2280 a few comments
|
|
"Please verify your account in order to ..." is vague. It will not be clear
to the user what they need to do in order to verify the account or even
what verify the account means. We have to say something along the lines of
"Please check your inbox for an email message from GraphSpace that will
contain an URL that you should visit in order to verify your email address."
We also need to think about what to do if the user has not received the
email message or deleted it. Should we add an option to resend the message?
…On Sat, Mar 3, 2018 at 8:22 PM, Aditya Bharadwaj ***@***.***> wrote:
@lohani2280 <https://github.com/lohani2280> a few comments
- We may want a proper error message instead of User not verified. We
can say - "Please verify your account in order to log in to GraphSpace."
Can you find out what is the language used by other websites?
- Can you find out what is the content of the verification email sent
by other websites?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#368 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGkWUPNv2NR1SRHxKMP6UIjUQqm1VzcFks5ta0HTgaJpZM4SRdik>
.
|
|
@adbharadwaj, @tmmurali Sir, I think a content as follows would be appropriate for us- |
|
@tmmurali Sir, I am working on adding an option to resend the message and I will update you very soon. |
|
Ping @tmmurali @adbharadwaj |
|
@adbharadwaj @tmmurali I have resumed the work over this PR.It would be really helpful if you would comment regarding the content of the email to be sent to the user account. |
|
@lohani2280 Can you do a background research in what content is usually used for such email by different websites? |
|
@adbharadwaj I have actually done some research over the content. I have listed them in this GitHubGist. Please have a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to validate the email address of the user provided during registration, a confirmation email with activation link is sent to the email address and when the user clicks the link, the email address is verified and the account gets activated.
I have added a gif below showing the changes-
fixes #360