-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another system config: allow_user_to_change_email_address #1
Conversation
->with( | ||
$this->equalTo('allow_user_to_change_email_address'), | ||
$this->anything() | ||
)->willReturn($allowedToChangeDisplayName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be a different variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
protected $possibleActions = [ | ||
self::CREATE_USER => 'createUser', | ||
self::SET_PASSWORD => 'setPassword', | ||
self::CHECK_PASSWORD => 'checkPassword', | ||
self::GET_HOME => 'getHome', | ||
self::GET_DISPLAYNAME => 'getDisplayName', | ||
self::SET_DISPLAYNAME => 'setDisplayName', | ||
self::SET_EMAILADDRESS => 'setEMailAddress', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theronakpatel Where is this change coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akhil1508 In this file actions are defined. We already have setEMailAddress
function.
* check if the backend supports changing email addresses | ||
* | ||
* @return bool | ||
* @since 8.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its since 28.0.0? It's a change we are introducing now..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IG, current is 27.0.0, so yes from 28.0.0 @akhil1508
$backend->expects($this->any()) | ||
->method('implementsActions') | ||
->willReturnCallback(function ($actions) { | ||
if ($actions === \OC\User\Backend::SET_DISPLAYNAME) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SET_EMAILADDRESS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes @akhil1508
@akhil1508 I updated nextcloud#40796 |
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
TODO
Checklist