use ical lib in view ics #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhieF
requested review from
theronakpatel,
akhil1508,
fahim44 and
avinash-0007
|
@PhieF The "before" section of description should show how |
plugins/view-ics/message.js
Outdated
| } else if (line.startsWith('END:VEVENT')) { | ||
| VEVENT = {}; | ||
| } | ||
| console.log(ICAL.parse(text)); |
There was a problem hiding this comment.
Remove console.log if not needed
fahim44
approved these changes
Sep 10, 2024
|
@PhieF Why we are not showing Organizer? I think that is also important . |
avinash-0007
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a mr to use another lib to parse ics and get better results
Before:
After:
currently available in dev server, using akhil767 account