-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slide bug with touch scroll #465
Comments
Same problem here. Screen_Recording_20220929_235253_Chrome.mp4 |
The same problem occurs when resizing the window with a PC as shown in the below video. There is probably some problem with the gestures Untitled.mp4 |
This is now fixed in v7.1.2, thanks for opening the issue! I added a new option |
Actually this is not related to the same bug, but it is valid issue |
Should I write an other issue just for this problem? |
@davide1995 In v7.1.2 it was enhanced, now it goes back to the correct slide, but that effect of sliding won't be fixed easily, at least to my knowledge. check out how it behaves with the new version, I think it is acceptable now. |
Yes, the scroll issue was solved with version 7.1.2 thank you. In my opinion, however, I think that by resizing the window the user should remain focused on the current side. But no problem, it's just a detail. Otherwise if I have time I'll propose a solution with a pull request |
What is the expected behavior?
When I touch the image, it should not move.
When I touch and move down / up, it shouldn't try to switch to the next item.
What is the current behavior?
Once i touch and move, it will try to slide to the next
What are the steps to reproduce?
https://stackblitz.com/edit/ngx-gallery
open the starter with a smartphone and try to scroll down in google chrome.
Another way to see the odd slide glitch is to open the lightbox, an touch and move up/down at the right side (below the arrow button).
What is the use-case or motivation for changing an existing behavior?
To support a nice user experience, it slide unless a tiny threshold is reached to left/right slide.
Which versions are you using for the following packages?
(the ones in the StackBlitz starter)
Is there anything else we should know?
Eventually this makes sense to fix with the replacement of hammerjs (#452) or it might be already fixed with it.
The text was updated successfully, but these errors were encountered: