-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter description not encoded correctly #213
Comments
|
@MurhafSousli It does appear they support it though. If I manually encode the requested URL then it does appear correctly. |
Ok, then the description needs to be encoded before https://stackblitz.com/edit/ngx-sharebuttons-jaakcs?file=app/app.module.ts |
Encode special characters in meta tags, closes #213
Bug Report or Feature Request (mark with an
x
)OS and Version?
Linux dustin-ws 4.13.0-32-generic #35-Ubuntu SMP Thu Jan 25 09:13:46 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Versions
Angular CLI: 1.6.4
Node: 6.11.5
OS: linux x64
Angular: 5.2.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
angular/cli: 1.6.4
angular-devkit/build-optimizer: 0.0.38
angular-devkit/core: 0.0.25
angular-devkit/schematics: 0.0.48
ngtools/json-schema: 1.1.0
ngtools/webpack: 1.9.4
schematics/angular: 0.1.13
schematics/schematics: 0.0.13
typescript: 2.5.3
webpack: 3.10.0
"ngx-share/core": "^5.0.0"
Repro steps
<a shareButton="twitter" sbUrl="https://example.com" sbDescription="@LoveMHz #TestTag test #Test">Share on Twitter
The log given by the failure
The Twitter URL gets encoded as "https://twitter.com/intent/tweet?url=https%3A%2F%2Fexample.com&text=@LoveMHz%20#TestTag test #Test"
Which results in the tweet being "@LoveMHz https://example.com"
Desired functionality
The text attribute being properly encoded as "%40LoveMHz%20%23TestTag%20test%20%23Test" and for the tweet to read as "@LoveMHz #TestTag test #Test"
The text was updated successfully, but these errors were encountered: