Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two commits highlighted when left mouse button clicked and held over commit list. #699

Closed
jensenr30 opened this issue Feb 23, 2024 · 1 comment · Fixed by #701
Closed
Assignees

Comments

@jensenr30
Copy link
Contributor

This bug seems pretty simple; I could probably fix it. Feel free to assign to me.

Steps to reproduce bug:

  • left click (and hold) on a commit in the list of commits
  • drag the mouse up or down past a few other commits
  • release left mouse button

At this point, two commits will be highlighted. See attached video.

I originally thought this was a bug, but maybe it could be turned into a feature! It would be pretty nifty to make the light-blue highlighter continue to follow the cursor around regardless of whether the mouse button is held down or not. It helps me visually the eye line up commit circles, commit messages, and the author/date.

Thoughts?

P.S.
Pay no attention to all the "gitslam!" commits in my repo in the video - its just a personal repo that no one else uses.

tmp.webm
@Murmele
Copy link
Owner

Murmele commented Feb 23, 2024

Yes this could be interesting, it is confusing that it stops highlighting another commit just when released. Thanks for assigning your self :)

jensenr30 added a commit to jensenr30/Gittyup that referenced this issue Feb 25, 2024
Qt was adding additional highlighting that was distracting.  This commit
fixes that issue by manually drawing the highlighted background color
instead of relying on Qt to do that.
See
Murmele#699
jensenr30 added a commit to jensenr30/Gittyup that referenced this issue Feb 25, 2024
Qt was adding additional highlighting that was distracting.  This commit
fixes that issue by manually drawing the highlighted background color
instead of relying on Qt to do that.
See
Murmele#699
jensenr30 added a commit to jensenr30/Gittyup that referenced this issue Mar 20, 2024
Qt was adding additional highlighting that was distracting.  This commit
fixes that issue by manually drawing the highlighted background color
instead of relying on Qt to do that.
See
Murmele#699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants