Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arch PKGBUILD #16

Closed
wants to merge 1 commit into from
Closed

Update Arch PKGBUILD #16

wants to merge 1 commit into from

Conversation

Grafcube
Copy link
Contributor

Updated the old PKGBUILD for Gittyup.

  • Changed name to gittyup-git since it builds from master. If there are tagged commits with the version numbers I can also also add gittyup package and if prebuilt releases are added, maybe to the releases section, I can make a gittyup-bin.
  • Build steps were copied from the readme. I am not sure if it's correct because I'm not too familiar with cmake and ninja. It builds and installs correctly on all three of my machines.
  • Included svg icon to be installed.

If it's ok, I don't mind also putting this on the AUR.

@Murmele
Copy link
Owner

Murmele commented Nov 14, 2021

Hi, can you rebase or merge master and trying again? I changed a few things in the cmake file so we can check that it does not collide

@Grafcube
Copy link
Contributor Author

Latest master fails to build. Specifically, it fails on ninja package in the package() function.

Here's the output:

[0/1] Run CPack packaging tool...
CPack: Create package using STGZ
CPack: Install projects
CPack: - Install project: Gittyup []
CMake Error at /home/USERNAME/gittyup-git/src/gittyup-git/build/release/pack/cmake_install.cmake:84 (file):
  file INSTALL cannot copy file "/usr/lib/libQt5Concurrent.so.5.15.2" to
  "/usr/local/lib/libQt5Concurrent.so.5": Permission denied.
Call Stack (most recent call first):
  /home/USERNAME/gittyup-git/src/gittyup-git/build/release/cmake_install.cmake:51 (include)


CMake Error at /home/USERNAME/gittyup-git/src/gittyup-git/build/release/pack/cmake_install.cmake:102 (file):
  file INSTALL cannot copy file "/usr/lib/libQt5Core.so.5.15.2" to
  "/usr/local/lib/libQt5Core.so.5": Permission denied.
Call Stack (most recent call first):
  /home/USERNAME/gittyup-git/src/gittyup-git/build/release/cmake_install.cmake:51 (include)


CMake Error at /home/USERNAME/gittyup-git/src/gittyup-git/build/release/pack/cmake_install.cmake:120 (file):
  file INSTALL cannot copy file "/usr/lib/libQt5Gui.so.5.15.2" to
  "/usr/local/lib/libQt5Gui.so.5": Permission denied.
Call Stack (most recent call first):
  /home/USERNAME/gittyup-git/src/gittyup-git/build/release/cmake_install.cmake:51 (include)


CMake Error at /home/USERNAME/gittyup-git/src/gittyup-git/build/release/pack/cmake_install.cmake:138 (file):
  file INSTALL cannot copy file "/usr/lib/libQt5Network.so.5.15.2" to
  "/usr/local/lib/libQt5Network.so.5": Permission denied.
Call Stack (most recent call first):
  /home/USERNAME/gittyup-git/src/gittyup-git/build/release/cmake_install.cmake:51 (include)


CMake Error at /home/USERNAME/gittyup-git/src/gittyup-git/build/release/pack/cmake_install.cmake:156 (file):
  file INSTALL cannot copy file "/usr/lib/libQt5PrintSupport.so.5.15.2" to
  "/usr/local/lib/libQt5PrintSupport.so.5": Permission denied.
Call Stack (most recent call first):
  /home/USERNAME/gittyup-git/src/gittyup-git/build/release/cmake_install.cmake:51 (include)


CMake Error at /home/USERNAME/gittyup-git/src/gittyup-git/build/release/pack/cmake_install.cmake:174 (file):
  file INSTALL cannot copy file "/usr/lib/libQt5Widgets.so.5.15.2" to
  "/usr/local/lib/libQt5Widgets.so.5": Permission denied.
Call Stack (most recent call first):
  /home/USERNAME/gittyup-git/src/gittyup-git/build/release/cmake_install.cmake:51 (include)


CMake Error at /home/USERNAME/gittyup-git/src/gittyup-git/build/release/pack/cmake_install.cmake:192 (file):
  file INSTALL cannot copy file "/usr/lib/libQt5Test.so.5.15.2" to
  "/usr/local/lib/libQt5Test.so.5": Permission denied.
Call Stack (most recent call first):
  /home/USERNAME/gittyup-git/src/gittyup-git/build/release/cmake_install.cmake:51 (include)


CPack Error: Error when generating package: Gittyup
FAILED: CMakeFiles/package.util
cd /home/USERNAME/gittyup-git/src/gittyup-git/build/release && /usr/bin/cpack --config ./CPackConfig.cmake
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in package().
    Aborting...
error: failed to build:

@Grafcube Grafcube mentioned this pull request Nov 14, 2021
@Murmele
Copy link
Owner

Murmele commented Nov 17, 2021

I checked out the CMakeLists.txt and there are install steps for the qtlibraries which is not neccesary, because they are as dependencies. I think we have to do something similar to that I did for the flatpak package.

@Grafcube can you check out how I did it for flatpak? (8a650d7)
Maybe renaming the "FLATPAK" variable to something like "INSTALL_DEPENDENCIES" and changing all ifs. I think also other packages will not need the dependencies.

@Grafcube
Copy link
Contributor Author

While I was working on the PKGBUILD it seems like someone already added another one to the AUR. That one builds correctly and it looks like it just needs minor changes to the name, icons, desktop entry and qt library.

https://aur.archlinux.org/packages/gittyup-git/

I'll just send a patch with the name and icons.

@Grafcube
Copy link
Contributor Author

Since there is a working AUR package this PR can be closed. Unless this should remain open for Qt dependencies?

@Murmele
Copy link
Owner

Murmele commented Nov 18, 2021

I think the best would be to maintain for the moment the flatpak package, because it is independend of any distro. I will create an issue for install process and cleanup of the CMakeLists.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants