Add a CI test to generate builds from the JSON api data and check differences #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musholic
force-pushed
the
test_generate_builds
branch
6 times, most recently
from
278412e to
34d44cf
Compare
Musholic
force-pushed
the
test_generate_builds
branch
from
34d44cf to
9f5728b
Compare
Musholic
force-pushed
the
dev
branch
2 times, most recently
from
55f897e to
1ecc3df
Compare
1 task
Musholic
force-pushed
the
dev
branch
5 times, most recently
from
4641a45 to
876cabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
In order to cover possible regressions across the build generation and stats calculations, this PR adds a busted task to generate build outputs (calcsTab.mainOutput and XML DB file) from JSON api character samples. Then a CI check can check if there are differences between the last generated outputs and a freshly generated ones.
The test is subject to false negatives due to the requirement of sorting the saved data (for reproducible output generation) but it's easy to solve them by replacing a
pairsbypairsSortByKey.The busted task requires the xmllint executable so it's recommended to run the command
docker compose upordocker compose up busted-generateto run the busted task on windows