Remove ToneJS types repo dep, use library typescript branch instead #4
Conversation
| @@ -27,7 +27,6 @@ | |||
| "devDependencies": { | |||
| "@types/jest": "^23.3.9", | |||
| "@types/node": "^10.12.5", | |||
| "@types/tone": "https://github.com/Tonejs/TypeScript.git", | |||
There was a problem hiding this comment.
You mentioned TypeScript definitions come from TypeScript branch. I don't see you select the branch anywhere here? Can you explain?
There was a problem hiding this comment.
I changed Tone version to 14.5.23.
Here https://www.npmjs.com/package/tone this version is tagged as "typescript" (under "512 versions" tab)
There was a problem hiding this comment.
Ah, that's how it works. Thank you for showing me this.
|
Witam, PanMichal. I need to add TravisCI auto builds so we're looking at the same output when verifying PR. I merged both RP's a bit blindfolded and fighting with this now although seems a bit of a red herring fsevents/fsevents#246 Probably completely unrelated when versions match. |
|
Hi Peter! |
|
I'm running |
|
@panmichal all PR's should now build in travis for verification, i triggered first manually, started with 4 node versions 10 11 12 13, we can drop some if we decide so. Check this out. All 4 failed. |
|
yarn issue with optional dependencies (mac yes, linux no) related to enforced fsevents version switched travis to run build on mac because of above bug |
|
Great with Travis! |
The specified ToneJS version points to the typescript branch.
Should solve #3