Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

MEW and Trezor security concern, with EIP 155 implementation #30

Closed
immartian opened this issue Aug 21, 2017 · 2 comments
Closed

MEW and Trezor security concern, with EIP 155 implementation #30

immartian opened this issue Aug 21, 2017 · 2 comments
Labels
enhancement

Comments

@immartian
Copy link
Contributor

immartian commented Aug 21, 2017 •
edited
Loading

As pointed by MyEtherWallet/etherwallet#912 (comment) we may need to consider a fast-forward implementation with EIP 155 before UBI. It seems time is quite limited, so another option is to put to v2.x .

Really appreciate MEW community to point this out.
@trustfarm-dev
Copy link

https://github.com/trezor/trezor-mcu/pull/212/files/1984a7675b4c7edf18b5aa1cf16c894eb82d153a#diff-12950855dc4a2a268fb19ece6da37668

EIP 155 doesn't applied on GMC.
So, I applied MUSICoin on MEW, with EIP 155 supports False on MEW.
In case of Musicnode has replay protection contract , then It will be protecting replay attack.
Early method of ETC has forked.

@immartian
Copy link
Contributor Author

https://twitter.com/andrebaars100/status/899621758457827328

@immartian immartian changed the title EIP 155 implementation MEW and Trezor security concern, with EIP 155 implementation Aug 21, 2017
@5chdn 5chdn mentioned this issue Oct 22, 2017
Merged
@ghost ghost mentioned this issue Feb 22, 2018
Merged
@5chdn 5chdn closed this as completed in #62 Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@immartian @5chdn @trustfarm-dev