Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

2.6.0: Propose replay attack protection hardfork at 2000000, ref #44 #62

Merged
merged 8 commits into from
Feb 22, 2018
Merged

2.6.0: Propose replay attack protection hardfork at 2000000, ref #44 #62

merged 8 commits into from
Feb 22, 2018

Conversation

5chdn
Copy link
Collaborator

@5chdn 5chdn commented Oct 22, 2017 •
edited
Loading

Closes #30

Closes #44

Closes #79

  • enables EIP 150 on block 2000000
  • enables EIP 155 on block 2000000
  • enables EIP 158 on block 2000000
  • enables Byzantium on block 2000000

Test instructions in #79

@5chdn 5chdn closed this Dec 30, 2017
@5chdn 5chdn reopened this Jan 29, 2018
@5chdn 5chdn mentioned this pull request Jan 29, 2018
Closed
@trustfarm-dev
Copy link

trustfarm-dev commented Jan 29, 2018 •
edited
Loading

EIP 158 will no effect on this fork.
158 is remove spam tx (null) tx , when contract gas ddos Oct 2016, in ethereum main chain.
make slim and decrease chain size.
here musicoin chain no spam tx in main chain, so, it is no-problem, it will on or not.
anyway, no problem.

@trustfarm-dev
Copy link

And, 1987654 block heights is not a meaning on this time.
Many peer nodes needs to update time and tests, before softforks.
so, 2M (end of feb) is proper choice of block number.
and, many guys easily identifying and remember softfork blocknumber on the view of human.

@5chdn 5chdn changed the title Propose replay attack protection hardfork at 1987654, ref #44 Propose replay attack protection hardfork at 2000000, ref #44 Jan 30, 2018
@5chdn
Copy link
Collaborator Author

5chdn commented Jan 30, 2018

Updated block fork number to 2_000_000 and merged #74

Having EIP-158 is a no-brainer, does not hurt :)

@trustfarm-dev
Copy link

Go : -)

@5chdn 5chdn changed the title Propose replay attack protection hardfork at 2000000, ref #44 2.6.0: Propose replay attack protection hardfork at 2000000, ref #44 Feb 8, 2018
@5chdn
Copy link
Collaborator Author

5chdn commented Feb 8, 2018

Bumps version to 2.6.0 to distinguish the build

@5chdn
Copy link
Collaborator Author

5chdn commented Feb 8, 2018 •
edited
Loading

Edit: See #79

@5chdn 5chdn mentioned this pull request Feb 8, 2018
Closed
ghost
ghost approved these changes Feb 21, 2018
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5chdn needs update

@5chdn 5chdn merged commit 0257438 into Musicoin:master Feb 22, 2018
@5chdn 5chdn deleted the a5-fork branch February 22, 2018 10:34
5chdn added a commit that referenced this pull request Feb 22, 2018
@5chdn
Merge pull request #83 from akx20000a/a5-fork
3678b99 
2.6.0: Propose MCIP-6 hardfork at 2018001, ref #44 & #62
This was referenced Jul 30, 2018
Merged
Merged
mkrufky added a commit to mkrufky/etherwallet that referenced this pull request Aug 30, 2018
@mkrufky
Add Ledger support for Musicoin
6fbff26 
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S

    homepage           : https://musicoin.org
    block explorer     : https://explorer.musicoin.org
    slip0044 index     : 184
    chainId            : 7762959

Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c

The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62

Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support

LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
@mkrufky mkrufky mentioned this pull request Aug 30, 2018
Merged
mkrufky added a commit to mkrufky/etherwallet that referenced this pull request Aug 30, 2018
@mkrufky
Add Ledger support for Musicoin
1de8d83 
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S

    homepage           : https://musicoin.org
    block explorer     : https://explorer.musicoin.org
    slip0044 index     : 184
    chainId            : 7762959

Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c

The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62

Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support

LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
mkrufky added a commit to mkrufky/etherwallet that referenced this pull request Aug 30, 2018
@mkrufky
Add Ledger support for Musicoin
fe7e749 
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S

    homepage           : https://musicoin.org
    block explorer     : https://explorer.musicoin.org
    slip0044 index     : 184
    chainId            : 7762959

Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c

The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62

Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support

LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
@mkrufky mkrufky mentioned this pull request Sep 15, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5chdn @trustfarm-dev