Add support for Musicoin #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this is vg from the Musicoin Team, I can confirm that we had EIP155 replay protection enabled with the hardfork at block 2,222,222 in accordance with https://github.com/Musicoin/MCIPs/blob/master/MCIPS/mcip-6.md. Please @me in case you need additional info. |
mkrufky
added a commit
to mkrufky/etherwallet
that referenced
this pull request
Aug 30, 2018
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S
homepage : https://musicoin.org
block explorer : https://explorer.musicoin.org
slip0044 index : 184
chainId : 7762959
Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62
Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support
LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
mkrufky
added a commit
to mkrufky/etherwallet
that referenced
this pull request
Aug 30, 2018
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S
homepage : https://musicoin.org
block explorer : https://explorer.musicoin.org
slip0044 index : 184
chainId : 7762959
Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62
Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support
LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
mkrufky
added a commit
to mkrufky/etherwallet
that referenced
this pull request
Aug 30, 2018
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S
homepage : https://musicoin.org
block explorer : https://explorer.musicoin.org
slip0044 index : 184
chainId : 7762959
Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62
Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support
LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
This was referenced Sep 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Musicoin
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S
Musicoin has been unable to work with hardware wallets until the following changes were applied:
8260268
74c085c
The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62