-
Notifications
You must be signed in to change notification settings - Fork 57
Replay attack protection - EIP155, BIP44 #44
Comments
Comment by Varunram We should set |
Comment by immartian We know how to do it but it takes a lot of test with risking the timeline of UBI. It's not a security issue, just confined to MEW and Trezor. It'll be in timeline after UBI's deployment, together with other EIPs Ethereum brought later. Let's focus on many delayed works first. |
Comment by Varunram Okay, so here are the things to do with BIP44.
As you said, not really on the fore front with UBI incoming, but we need to keep this in mind since many people are commenting on the lack of MEW support in general. We can see this after UBI :) |
@immartian @Varunram Yes it's good approach,
|
@trustfarm-dev did you try the most recent Parity version of $MUSIC ? #47 I can build one if you want to try. |
@immartian not yet and little time , even though holiday 👍 -) And, I think more emergent things are review the contract code of DEV fund/Foundation fund security, before UBI 2.0 fork. |
Yes, we are doing, on security part. The reason to suggest Parity is we have adopted upstream codebase of Ethereum there. So the replay attack should be solved. GMC will follow up, soon. |
Yes I think so, latest parity code will have Easily adapt EIP-155 and BIP for chainid. |
enabling EIP-155 in parity is just a change in the chain spec. 👍 |
@trustfarm-dev love to test? |
@immartian I've already built parity 1.8 music as you know. |
Ref. #74 for PR |
2.6.0: Propose replay attack protection hardfork at 2000000, ref #44
Issue by Varunram
Saturday Aug 26, 2017 at 14:00 GMT
Originally opened as https://github.com/Musicoin/PM/issues/117
We have to add Replay Attack Prevention (EIP 155) which has been referenced over at the go-musicoin repository. I've added the steps t doing this below.
On the way to adding EIP 155 support there exists<a href="https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki'> this issue with BIP 44 that we must comply with. Once we comply with BIP 44, we can get back on MEW and once we somehow implement EIP 155, we can shut the haters over at the MEW repo.
Let's set a timeline for this before/after UBI,
The text was updated successfully, but these errors were encountered: