Nwc sql #28
Merged
Nwc sql #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
force-pushed
the
nwc-sql
branch
2 times, most recently
from
167b9fc
to
8d5f554
Compare
TonyGiorgio
force-pushed
the
nwc-sql
branch
2 times, most recently
from
cbee208
to
c5c60e1
Compare
|
Works locally, just need to deploy onto staging and test there. |
| event.tags.extend(tags); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
doing the tags like this might cause the signatures to be invalid, the tags need to be in the same order as before, should at least add a debug_assert to verify the signature is good.
There was a problem hiding this comment.
Probably just need to sort by id to get in the correct order
There was a problem hiding this comment.
Nostr is retarded if that's the case
There was a problem hiding this comment.
- I log and remove events that don't verify
- NWC messages should be unaffected since they only have one tag
- tag inserts happen in order and they are now retrieved by an order by id.
benthecarman
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably doesn't work yet but it compiles and it's a start.
Will start testing tomorrow.