Makes the bdk & ldk forks simpler #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temp solution related to this: lightningdevkit/rust-lightning#2003 |
TonyGiorgio
force-pushed
the
simple-forks
branch
from
aff5f13 to
5a68cc5
Compare
|
Removed the LDK fork since we don't need it to have esplora yet (removed Could probably remove the BDK fork with bdk core upgrade so I didn't bother touching that besides to move it over to our repo. |
Looks like bdk 28.0 will allow us to remove the fork. Eventually when bdk core is ready for no-std we can move to that as well. |
benthecarman
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved our bdk & ldk forks into the MutinyWallet github for easier access to the whole team.
The BDK fork is here: MutinyWallet/bdk#1
It is copied from ben's tmp fork. Mostly dependency updates.
Actually didn't need the LDK fork, so I forced pushed. Since we are using our own
lightning-transaction-sync, we have no reason for updating esplora.I have copied the
lightning-transaction-syncfiles into our ownesplora.rsbecause of someSend + Syncissues. It's really just like 5 lines of code changed there but it would have been a fork nevertheless.