Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for indexing audio reclaim command #44

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Add support for indexing audio reclaim command #44

merged 2 commits into from
Jun 13, 2023

Conversation

reyraa
Copy link
Member

@reyraa reyraa commented Jun 10, 2023 •
edited
Loading

What was the problem?

This PR resolves #26

How was it solved?

  • This PR must be merged after the audio:stream PR. It is based on said PR and the merge order matters.
  • I'm updating the audio income value, and since I use the token transfer method (in the blockchain) to transfer the income to the artist account, we don't have to worry about that in Streamer, it is already handled by the token module.

How to test it

  • Create a collection, and the an audio
  • Stream the audio
  • Reclaim the income
  • Check the balances in each step to spot the changes.

@reyraa reyraa self-assigned this Jun 10, 2023
@reyraa reyraa requested review from haghighatcs and curvesy June 10, 2023 21:42
@reyraa reyraa marked this pull request as ready for review June 10, 2023 21:46
@reyraa reyraa linked an issue Jun 10, 2023 that may be closed by this pull request
Add support for indexing Audio Reclaim command #26
Closed
haghighatcs
haghighatcs previously approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@haghighatcs haghighatcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyraa reyraa dismissed haghighatcs’s stale review June 13, 2023 17:20

The merge-base changed after approval.

@reyraa reyraa changed the base branch from feature/adapt-to-muzikie to development June 13, 2023 17:20
@reyraa reyraa changed the base branch from development to feature/adapt-to-muzikie June 13, 2023 17:20
haghighatcs
haghighatcs approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@haghighatcs haghighatcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyraa reyraa merged commit 3421286 into feature/adapt-to-muzikie Jun 13, 2023
@reyraa reyraa deleted the 26-add-support-for-indexing-audio-reclaim-command branch June 13, 2023 17:28
@haghighatcs haghighatcs mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haghighatcs haghighatcs haghighatcs approved these changes

@curvesy curvesy Awaiting requested review from curvesy

Assignees

@reyraa reyraa

Labels
None yet
Projects
No open projects
Streamer Version 0.3.0
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for indexing Audio Reclaim command
2 participants
@reyraa @haghighatcs