Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return audios by collectionID and ownerAddress #49

Conversation

curvesy
Copy link
Contributor

@curvesy curvesy commented Jun 26, 2023

What was the problem?

Closes #47

We need to return audios based on the following params:

  • collectionID
    We need this to display audios of a given collection. For example, when you open the page to a music album.
  • ownerAddress
    This is used for collecting the list of audios that a user owns shares of. We'll use this in the profile page, and also for
    reclaiming the profit. keep in mind the reclaim transaction doesn't need this endpoint param, it performs the job
    internally. But we need to show the audio profits in a dedicated list to he artist.

How was it solved?

  • Add collectionID and ownerAddress parameters to the gateway API for the audios
  • Get the list of Audios for addresse have share > 0

How was it tested?

It tested Manualy

@curvesy curvesy self-assigned this Jun 26, 2023
@curvesy curvesy requested review from haghighatcs and reyraa June 26, 2023 13:20
reyraa
reyraa previously approved these changes Jul 4, 2023
@reyraa reyraa removed the request for review from haghighatcs July 4, 2023 18:47
@reyraa reyraa merged commit bb89c33 into feature/adapt-to-muzikie Jul 4, 2023
@reyraa reyraa deleted the 47-return-audios-by-collectionid-and-owneraddress branch July 4, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants