Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues discovered with collection transactions indexing mechanism #53

Conversation

curvesy
Copy link
Contributor

@curvesy curvesy commented Jul 10, 2023

What was the problem?

Resolves #39

The setAttribute.js file in the indexer use the unexpected function updateCollection and relies on event data instead of the
required transaction parametrs.

How was it solved?

  • Remove event data from the setAttribute, and transfer command tx processor
  • Remove the attributeSet file
  • Remove updateCollection function to match the other commands
  • Remove blank lines, multiple white spaces and other syntax issues not caught by the linter.

How was it tested?

manually

@curvesy curvesy changed the base branch from development to feature/adapt-to-muzikie July 10, 2023 13:52
@reyraa reyraa requested review from haghighatcs and reyraa and removed request for reyraa July 12, 2023 10:39
@reyraa reyraa merged commit e25620c into feature/adapt-to-muzikie Jul 13, 2023
@reyraa reyraa deleted the 39-fix-issues-discovered-with-collection-transactions-indexing-mechanism branch July 13, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants