Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Babel sample (WPF & Android) #136

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PoLaKoSz
Copy link

@PoLaKoSz PoLaKoSz commented May 14, 2019

Thank You for this great library!

Although I have read the Don't "Push" Your Pull Requests I could not find any example in this repo how to make this code review more easy because I upgraded the project from 4.0.0-beta8 to 6.2.3 .

📓 Notes

  • upgraded Android
    • minSDK to 19
    • targetSDK to 19
  • I could not upgrade these:
    • Babel.Ios
    • Babel.Phone
    • Babel.Store

Reference #122

@dnfclas
Copy link

dnfclas commented May 14, 2019

CLA assistant check
All CLA requirements met.

Babel/Babel.Droid/Babel.Droid.csproj Outdated Show resolved Hide resolved
Babel/Babel.Droid/Setup.cs Show resolved Hide resolved
Babel/Babel.Droid/packages.config Outdated Show resolved Hide resolved
Babel/Babel.Wpf/Setup.cs Show resolved Hide resolved
@PoLaKoSz PoLaKoSz closed this May 30, 2019
@PoLaKoSz PoLaKoSz reopened this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants