FIX reset or forgot mails #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extMailService.sendHTMLMail(applicationConfiguration.notifyEmail, applicationConfiguration.siteName, | ||
| recipientFields, | ||
| Collections.singletonList(MailRecipientField(user.username, user.username)), |
There was a problem hiding this comment.
We should use listOf instead of Collections.singletonList. of course, both works but I prefer to use the existing Kotlin API in Kotlin source instead of Java library. We can write the code like listOf(MailRecipientField(user.username, user.username))
| @@ -164,7 +164,7 @@ private Component generateMemberBlock(SimpleUser member) { | |||
|
|
|||
| if (RegisterStatusConstants.NOT_LOG_IN_YET.equals(member.getRegisterstatus())) { | |||
| MButton resendBtn = new MButton(UserUIContext.getMessage(UserI18nEnum.ACTION_RESEND_INVITATION), clickEvent -> { | |||
| SendUserInvitationEvent invitationEvent = new SendUserInvitationEvent(member.getUsername(), "", | |||
| SendUserInvitationEvent invitationEvent = new SendUserInvitationEvent(member.getUsername(), member.getPassword(), | |||
There was a problem hiding this comment.
If you debug the password value, then you know this password is encrypted and we don't know the original one. So the password (if any) we send to the user in this case can not be used to log in the system.
If we resend the invitation, the user can get the password in the previous email. If they can't get this email, he can use the forgot password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.