Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix a type annotation in RuleSet #1039

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[BUGFIX] Fix a type annotation in RuleSet #1039

wants to merge 1 commit into from
+23 −30

Conversation

oliverklee
Copy link
Contributor

Also improve some variable names.

Part of #756.

@oliverklee oliverklee requested a review from JakeQZ February 28, 2025 21:35
@oliverklee oliverklee self-assigned this Feb 28, 2025
@coveralls
Copy link

coveralls commented Feb 28, 2025 •
edited
Loading

Coverage Status

coverage: 55.948% (-0.06%) from 56.006%
when pulling f36699b on cleanup/hungarian/property-or-rule-name
into 54ca442 on main.

@oliverklee oliverklee force-pushed the cleanup/hungarian/property-or-rule-name branch 3 times, most recently from 0349db6 to 25b661b Compare March 2, 2025 14:06
@oliverklee
[BUGFIX] Fix a type annotation in RuleSet
f36699b 
Also improve some variable names.

Part of #756.
@oliverklee oliverklee force-pushed the cleanup/hungarian/property-or-rule-name branch from 25b661b to f36699b Compare March 2, 2025 19:32
@oliverklee oliverklee marked this pull request as draft March 2, 2025 20:35
@oliverklee oliverklee removed the request for review from JakeQZ March 2, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliverklee oliverklee

Labels
bug cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @coveralls