-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Do not allow string values for rules anymore #353
base: main
Are you sure you want to change the base?
Conversation
String values had not been allowed for rules, and should not be. (Passing string values was a bug in the Emogrifier library.) @see MyIntervals/emogrifier#1144 This reverts commit 67a6e95.
I’m not sure this is true. When the rule value is an identifier, it will be a string stored in .test {
white-space: nowrap;
} will parse into the following
|
AFAICT the type for |
Would introducing an
It seems that the default, with no value having been set, does not represent a valid property declaration. This would not arise from parsing, since The constructor enforces that a key is provided. Maybe it should also enforce that a value is provided - though that would be a BC. |
Marking this as draft for now. I'd like to pick this up again when we've covered the code with more unit tests. After that, I'd like to reduce multi-types as much as possible in order to simplify things and help static analysis. |
String values had not been allowed for rules, and should not
be. (Passing string values was a bug in the Emogrifier
library.)
@see MyIntervals/emogrifier#1144
This reverts commit 67a6e95.