[TASK] Avoid Hungarian notation in a class

[oliverklee]

This change does not include any breaking changes.

[JakeQZ]

According to the deprecation policy discussion - #453 (comment) - we should provide magic methods to access the new property names via the old names, marking the old names deprecated.

[JakeQZ]

we should provide magic methods to access the new property names via the old names, marking the old names deprecated.

The PublicPropertyDeprecationTrait class from TYPO3 along with associated TestCase look ideal for the job, assuming the licence is compatible.

[JakeQZ]

This change does not include any breaking changes.

The renamed properties are protected, so this would break any subclass accessing them directly.

[JakeQZ]

The renamed properties are protected, so this would break any subclass accessing them directly.

I think we should also make them private as part of this change. (But do still need to deprecate them first.)

The PublicPropertyDeprecationTrait class from TYPO3 along with associated TestCase look ideal for the job

I think I've spotted a mistake in the class: __isset() should return isset($this->$propertyName) in all branches. (The other magic methods do the equivalent, and look correct.)

[JakeQZ]

The PublicPropertyDeprecationTrait class from TYPO3 along with associated TestCase look ideal for the job

Looking again, this only provides for deprecation without renaming (i.e. changing to access to private). To support renaming and deprecation at the same time, there'd also need to be a map from old property names to new ones.

[oliverklee]

Marking as draft for now - I think I'd like to change our policy for public APIs.

[oliverklee]

With our new API and deprecation policy in place, I think this is unblocked now.

[coveralls]

coverage: 38.652%. remained the same
when pulling 80ceae6 on task/no-hungarian-6
into 76076de on main.

[JakeQZ]

With our new API and deprecation policy in place, I think this is unblocked now.

Yes, the API policy says that classes should not be extended, so protected methods are effectively internal.