Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FOLLOWUP] Use the PHP 7.2 language level for Rector #776

Merged
merged 1 commit into from
Nov 17, 2024
Merged

[FOLLOWUP] Use the PHP 7.2 language level for Rector #776

merged 1 commit into from
Nov 17, 2024

Conversation

oliverklee
Copy link
Contributor

Followup to #771

@oliverklee oliverklee self-assigned this Nov 17, 2024
github-actions[bot]

This comment was marked as off-topic.

Sign in to view

@coveralls
Copy link

Coverage Status

coverage: 38.583%. remained the same
when pulling f539e54 on followup/rector-php-version
into 3eb42ce on main.

JakeQZ
JakeQZ approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@JakeQZ JakeQZ merged commit 428a2eb into main Nov 17, 2024
22 checks passed
@JakeQZ JakeQZ deleted the followup/rector-php-version branch November 17, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ