Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Allow assertInstanceOf calls in tests #780

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oliverklee
Copy link
Contributor

We find those checks useful.

@oliverklee oliverklee self-assigned this Dec 17, 2024
@oliverklee oliverklee marked this pull request as draft December 17, 2024 09:03
@coveralls
Copy link

coveralls commented Dec 17, 2024

Coverage Status

coverage: 38.583%. remained the same
when pulling 6370fe4 on task/assertinstanceof
into fe2eaa0 on main.

@oliverklee oliverklee force-pushed the task/assertinstanceof branch from 08906d1 to dbef139 Compare December 17, 2024 12:11
@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 17, 2024

Looks like this just needs a baseline update to remove the instanceof error which is now squished by the config change...

@oliverklee
Copy link
Contributor Author

Looks like this just needs a baseline update to remove the instanceof error which is now squished by the config change...

I tried that: It turns out that we currently do not have any of those warnings (I tend to put this on the fact that PHPStan is still at level 1 for this project), and blocklisting warnings we don't have (yet) is something that PHPStan does not support.

So I'll keep this PR sitting here for the time being and un-draft it once we actually have any of those warnings to ignore.

@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 19, 2024

Looks like this just needs a baseline update to remove the instanceof error which is now squished by the config change...

we currently do not have any of those warnings

Ah, I see. I misunderstood the error message (did not read it properly), and thought it was referring to an existing error that now needed to be removed from the baseline.

We find those checks useful.
@oliverklee oliverklee force-pushed the task/assertinstanceof branch from dbef139 to 6370fe4 Compare December 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants