[CLEANUP] Avoid Hungarian notation in CSSBlockList (part 2)
#851
Conversation
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
src/CSSList/CSSBlockList.php
Outdated
| $sComparator = $aSpecificitySearch[0]; | ||
| $iTargetSpecificity = $aSpecificitySearch[1]; | ||
| $comparator = '==='; | ||
| $specificitySearchResults = \explode(' ', $specificitySearch); |
There was a problem hiding this comment.
I think this should be named with something like 'parts', 'elements' or 'components'. The input string contains either a number (e.g. "1"), or an operator and a number (e.g. ">= 1"). The result goes into $result.
There was a problem hiding this comment.
Maybe $expressionParts?
There was a problem hiding this comment.
Yes I think that works. It's only used locally in that small section of code.
oliverklee
force-pushed
the
cleanup/hungarian-cssblocklist
branch
from
5a2b89f to
4bf8ee8
Compare
oliverklee
force-pushed
the
cleanup/hungarian-cssblocklist
branch
from
4bf8ee8 to
afdefc5
Compare
src/CSSList/CSSBlockList.php
Outdated
| switch ($sComparator) { | ||
| $targetSpecificity = (int) $targetSpecificity; | ||
| $selectorSpecificity = $selector->getSpecificity(); | ||
| $hasMatches = false; |
There was a problem hiding this comment.
Apologies, I missed this in the previous review.
I don't think "has" is correct here. The equivalent linguistic phrase is "it matches" rather than "it has matches" - i.e. "matches" is a verb rather than a noun.
There was a problem hiding this comment.
Better late than never. ;-) I've come up with a different name and repushed.
There was a problem hiding this comment.
Maybe comparatorMatched?
Part of #756