Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the required PHP version #226

Closed
rroblik opened this issue Aug 11, 2015 · 1 comment
Closed

Document the required PHP version #226

rroblik opened this issue Aug 11, 2015 · 1 comment
Assignees
Milestone

Comments

@rroblik
Copy link

rroblik commented Aug 11, 2015

Hi,

I've read nothing about PHP minimum version needed to be able to use Emogrifier.
I updated to last version, and my scripts stop working.

I think that it is because "new" (php 5.4+) array syntax :
private $excludedSelectors = [];

As i'm runing php 5.3.3 I need (and maybe other people) need to downgrade ...

Thanks to document.

@oliverklee oliverklee added this to the 1.0.0 milestone Aug 11, 2015
@oliverklee oliverklee changed the title Add php minimum version requirement Document the required PHP version Aug 11, 2015
@oliverklee
Copy link
Contributor

Thanks for the suggestion. Currently, it's only enforced (and kind of documented) in the composer.json. I'll take care of documenting it in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants