Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative attribute selectors a[href^="tel"] #227

Closed
wrabit opened this issue Sep 4, 2015 · 2 comments
Closed

Negative attribute selectors a[href^="tel"] #227

wrabit opened this issue Sep 4, 2015 · 2 comments
Labels
enhancement waiting for feedback

Comments

@wrabit
Copy link

wrabit commented Sep 4, 2015

Is this a known issue?
@wrabit wrabit changed the title Error on processing .a[href^="tel"] type selectors Error on processing a[href^="tel"] type selectors Sep 4, 2015
@oliverklee
Copy link
Contributor

No, not as far as I know.

@digitaloutback Could you please provide steps to reproduce the problem, the expected result and the actual result?

And would you be willing to provide a pull request that has a unit test for the problem and a fix? That would be awesome!

@oliverklee oliverklee added this to the 1.0.0 milestone Sep 4, 2015
@oliverklee oliverklee modified the milestones: 1.1.0, 1.0.0 Oct 10, 2015
@oliverklee oliverklee mentioned this issue Oct 20, 2015
Closed
@oliverklee oliverklee changed the title Error on processing a[href^="tel"] type selectors Negative attribute selectors a[href^="tel"] Nov 15, 2015
@oliverklee oliverklee removed this from the 1.1.0 milestone Nov 15, 2015
@oliverklee oliverklee mentioned this issue Nov 15, 2015
Closed
@MattiJarvinen
Copy link

Symfony css-selector would handle this but maybe just implementing these rules in Emogrifier would help a lot.

https://github.com/symfony/css-selector/blob/master/XPath/Extension/AttributeMatchingExtension.php#L34 and https://github.com/symfony/css-selector/blob/master/XPath/Extension/AttributeMatchingExtension.php#L110

Also adding support for adding xPathRules would be nice.

oliverklee pushed a commit that referenced this issue Jul 13, 2016
@oliverklee
[FEATURE] Support the attr^=value selector
30979db 
This is part of #321.

Fixes #324
Fixes #278
Fixes #227
@oliverklee oliverklee mentioned this issue Jul 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement waiting for feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliverklee @wrabit @MattiJarvinen