Removed strict return types and null coalescing for 5.6 support

MyOnlineStore · Aug 9, 2019 · b0de21b · b0de21b
1 parent 232360a
commit b0de21b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/Message/Response/CancelOrderResponse.php b/src/Message/Response/CancelOrderResponse.php
@@ -12,6 +12,10 @@ final class CancelOrderResponse extends FetchOrderResponse
      */
     public function isSuccessful()
     {
-        return 'canceled' === $this->data['status'] ?? '';
+        if (!isset($this->data['status'])) {
+            return false;
+        }
+
+        return 'canceled' === $this->data['status'];
     }
 }
diff --git a/tests/Message/CancelOrderRequestTest.php b/tests/Message/CancelOrderRequestTest.php
@@ -26,15 +26,15 @@ public function setUp()
         $this->request = new CancelOrderRequest($this->httpClient, $this->getHttpRequest());
     }
 
-    public function insufficientDataProvider(): array
+    public function insufficientDataProvider()
     {
         return [
             [['apiKey' => 'mykey']],
             [['transactionReference' => 'myref']],
         ];
     }
 
-    public function responseDataProvider(): array
+    public function responseDataProvider()
     {
         return [
             [['id' => 'ord_kEn1PlbGa'], false],
@@ -65,7 +65,7 @@ public function testGetDataWillReturnEmptyArray()
     /**
      * @dataProvider responseDataProvider
      */
-    public function testSendData(array $responseData, bool $success)
+    public function testSendData(array $responseData, $success)
     {
         $response = $this->createMock(ResponseInterface::class);
         $response->expects(self::once())
@@ -80,13 +80,11 @@ public function testSendData(array $responseData, bool $success)
                 ['Authorization' => 'Bearer mykey']
             )->willReturn($response);
 
-
         $this->request->initialize(['apiKey' => 'mykey', 'transactionReference' => 'ord_kEn1PlbGa']);
         $voidResponse = $this->request->sendData([]);
 
         $this->assertInstanceOf(CancelOrderResponse::class, $voidResponse);
         $this->assertEquals($success, $voidResponse->isSuccessful());
         $this->assertSame('ord_kEn1PlbGa', $voidResponse->getTransactionReference());
     }
-
 }