Frocksdb release guide and helping scripts (#4) (ververica#7)

Fix windows build bug and modify publish script
Myasuka · Dec 21, 2020 · bc9dd36 · bc9dd36
1 parent f586aea
commit bc9dd36
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/RELEASE-FROCKSDB.md b/RELEASE-FROCKSDB.md
@@ -16,12 +16,12 @@ Optionally:
 
     choco install intellijidea-community vscode
 
-Open git bash and run commands:
+Open developer command prompt for vs 2017 and run commands:
 
     git clone git@github.com:dataArtisans/frocksdb.git
     cd frocksdb
     git checkout FRocksDB-5.17.2 # release branch
-    java/crossbuild/build-win.bat
+    java\crossbuild\build-win.bat
 
 The result native library is `build\java\Release\rocksdbjni-shared.dll`.
 The result windows jar is `build\java\rocksdbjni_classes.jar`.

diff --git a/java/crossbuild/build-win.bat b/java/crossbuild/build-win.bat
@@ -12,5 +12,5 @@ cmake -G "Visual Studio 15 Win64" -DWITH_JNI=1 ..
 
 cd ..
 
-copy build\Release\rocksdb-shared.dll librocksdbjni-win64.dll
+copy build\java\Release\rocksdbjni-shared.dll librocksdbjni-win64.dll
 echo Result is in librocksdbjni-win64.dll
diff --git a/java/publish-frocksdbjni.sh b/java/publish-frocksdbjni.sh
@@ -20,23 +20,23 @@
 # fail on errors
 set -e
 
+PREFIX=java/target/frocksdb-release/frocksdbjni-${VERSION}
+
 function deploy() {
   FILE=$1
   CLASSIFIER=$2
-  echo "Deploying file=${FILE} with classifier=${CLASSIFIER} to sonatype"
+  echo "Deploying file=${FILE} with classifier=${CLASSIFIER} to sonatype with prefix=${PREFIX}"
   sonatype_user=${USER} sonatype_pw=${PASSWORD} mvn gpg:sign-and-deploy-file \
    --settings java/deploysettings.xml \
    -Durl=https://oss.sonatype.org/service/local/staging/deploy/maven2/ \
    -DrepositoryId=sonatype-nexus-staging \
-   -DpomFile=java/frocksdbjni-${VERSION}.pom \
+   -DpomFile=${PREFIX}.pom \
    -Dfile=$FILE \
    -Dclassifier=$CLASSIFIER \
    -Dgpg.keyname=${KEYNAME}  \
    -Dgpg.passphrase=${PASSPHRASE}
 }
 
-PREFIX=java/target/frocksdb-release/frocksdbjni-${VERSION}
-
 deploy ${PREFIX}-sources.jar sources
 deploy ${PREFIX}-javadoc.jar javadoc
 deploy ${PREFIX}.jar