-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run unit tests in Github Actions #125
Conversation
f185ed8
to
da08cb6
Compare
Newer dependencies contain code incompatible with Python 3.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and is working, did comment on the flake-8 test which can be partially activated to check for some common mistakes.
Discussing abit with @krisgesling yesterday and we've now updated to use test-requirements.txt to install pytest and flake8. The run_tests.py script is removed for the time being since it's not used anymore. testing instructions have been added to the readme for now. A new script should probably be created to allow running the flake8 and pytest... |
a1110c5
to
7d9b51e
Compare
7d9b51e
to
6e71c87
Compare
Since the flake command-line is non-trivial I pulled it out into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @forslund for pulling this across the line. Please open an issue for us to address/document&ignore the lint errors we're excluding with --select=E9,F63,F7,F82
Will write up an issue during the day. |
Description:
Adds automated testing for any new PR via Github Actions.
Intentionally commented out flake8 checks at the moment as these will fail on the current codebase.
How to test:
See automated checks below.
CLA