Issues/114 #128
Merged
Issues/114 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clusterfudge
force-pushed
the
issues/114
branch
from
e03bd82 to
e23c67b
Compare
forslund
reviewed
Apr 26, 2021
|
@forslund PTAL again. thanks! |
forslund
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
Also uncovered a bug where a method parameter ( Intent.validate_with_tags(self, tags,
confidence) ) was being overridden internally. The fix includes better variable names for confidence and parser_weight as appropriate, and does not break any existing tests.I've added an explicit test that fails in the example provided in #114 , and that test passes with this change.
CLA Signed