Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docstrings, and some small fixes #132

Merged
merged 5 commits into from
Jun 28, 2021

Conversation

clusterfudge
Copy link
Collaborator

  • Description of what the PR does, such as fixes # {issue number}
    Continuation of Improve the readability of Adapt #130

  • Description of how to validate or test this PR
    Primarily docstring changes, one function parameter passed through correctly. No test changes necessary.

  • Whether you have signed a CLA (Contributor Licensing Agreement)
    Signed

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements all around, I made a couple of nitpicky comments the thing that made me do a couple of retakes was the description for the iterator argument.

I approved the PR and you can disregard my comments if you don't agree with them.

adapt/tools/text/trie.py Outdated Show resolved Hide resolved
adapt/tools/text/trie.py Show resolved Hide resolved
adapt/tools/text/trie.py Outdated Show resolved Hide resolved
@forslund forslund added CLA: Yes Contributor License Agreement has been signed Documentation labels Jun 3, 2021
forslund
forslund previously approved these changes Jun 21, 2021
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all out of tiny nit-picks :) Looks great

@clusterfudge clusterfudge merged commit 8c31136 into master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement has been signed Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants