This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Flexible lang dialect support #1335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @JarbasAI! Thanks for updating the PR.
Comment last updated on October 03, 2018 at 12:21 Hours UTC |
forslund
added
the
CLA: Yes
|
|
Try en-gb
…On Wed, Feb 7, 2018, 7:36 PM JarbasAI ***@***.***> wrote:
https://www.reddit.com/r/Mycroftai/comments/7v0nom/noob_where_are_all_the_configuration_options/dtrom1n/
For example I am in the UK I see in the example there is the line
"lang": "en-us",
Naturally I assume that the UK equivalent is:
"lang": "en-uk",
But this causes my device to no understand any command.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1335 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFg_ikou4yZvVpW3TEimrNNlf6_0NtR7ks5tSa3wgaJpZM4RPMWx>
.
|
|
en-gb, en-uk, en-us, en-au, en ..... they all should work by default @neoscreenager , the difference should be minimal, no reasons for things to fail to load or should we copy and have the exact same files in slightly differently named folders? |
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Sep 2, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Sep 3, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Sep 5, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Sep 8, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Oct 7, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to HelloChatterbox/HolmesV
that referenced
this pull request
Oct 7, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI/mycroft-core#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 19, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 19, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 19, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 19, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 21, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 26, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 26, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 26, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Oct 26, 2021
when loading resources check for all language code variations and returns best path if lang is set to pt-pt but only pt-br resources exist, those will be loaded instead of skill failing changing language to en-gb should load british dialect variations if available, but en-us should still be used if en-gb missing! It's not a good enough reason to fail completely, this can be device breaking and greatly impacts user experience unmerged original PR - MycroftAI#1335
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support language code variations, adds a utility function and implements it in skills core where relevant
these check for language code variations, lets say we want to access "path/en-uk" , but it does not exist, this PR adds methods to check for "path/en" , "path/en-us" etc, and returns the best language alternative
skills in "en-us" will still work if i configure mycroft for "en-uk", or "es-es" skills will work if i configure mycroft lang for "es"