This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
wait_for_response method for synchronous messagebus communication #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client handles the basic case when wanting to do a syncronous request-response action. The method sets up a handler waits for the response and handles timeout. The expected format is that the reply message should have the same type as the original message with ".response" appended. An method in the Message class has been added to create a standard response for a message.
forslund
added
the
CLA: Yes
Fixed typos and refined text
Closed
antlarr
pushed a commit
to antlarr/mycroft-core
that referenced
this pull request
Feb 25, 2018
…croftAI#1423) * Add wait_for_response method to Websock client The client handles the basic case when wanting to do a syncronous request-response action. The method sets up a handler waits for the response and handles timeout. The expected format is that the reply message should have the same type as the original message with ".response" appended. An method in the Message class has been added to create a standard response for a message. * Let the :skills command use wait_for_response * Minor docstring changes Fixed typos and refined text
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The client handles the basic case when wanting to do a syncronous
request-response action.
The method sets up a handler waits for the response and handles timeout.
The expected format is that the reply message should have the same type as
the original message with ".response" appended.
An method in the Message class has been added to create a standard response for
a message.
How to test
Run cli and make sure :skills works as intended.
Contributor license agreement signed?
CLA [Yes]