Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Enable snowboy to use several wakeword models #2499

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

dalgwen
Copy link

@dalgwen dalgwen commented Mar 11, 2020

Snowboy could use several wakeword models, not only the first one.

Description

Fix #2498

How to test

Use snowboy, with several hotword model at the same time.
Every one of them should wake mycroft.

Contributor license agreement signed?

CLA [ ]
Not yet, I'm in processing. But I think that for a change this small, it will not be a problem ;-)

Snowboy could use several wakeword models, not only the first one.
@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Mar 11, 2020
@devs-mycroft
Copy link
Collaborator

Hello, @dalgwen, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@dalgwen
Copy link
Author

dalgwen commented Mar 11, 2020

I forgot to mention snowboy code documentation to back this modification :

// " In the case that more than one hotword exist in the
// provided models, RunDetection() will return the index of the hotword, if
// the corresponding hotword is triggered."

@forslund
Copy link
Collaborator

Thanks @dalgwen looks nice and simple. Will merge once the CLA is received. (We're require it for all contributions no matter how small so we are consistent)

@dalgwen
Copy link
Author

dalgwen commented Mar 11, 2020

It's OK, I just signed the CLA. 👍

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Mar 12, 2020
@krisgesling
Copy link
Contributor

Thanks @dalgwen.

Received the CLA. Merging now.

@krisgesling krisgesling merged commit 054498d into MycroftAI:dev Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using several models with snowboy hotword detection
4 participants