This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Update pyee to v7.0.1 #2507
Merged
Update pyee to v7.0.1 #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
the
Status: Work in progress
devs-mycroft
added
the
CLA: Yes
pyee has added ThreadExecutor variant of the EventEmitter which can replace the home-spun threadpool based emitter
forslund
removed
the
Status: Work in progress
|
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
|
Voight Kampff Integration Test Succeeded (Results) |
|
Looks good, thanks Ake! |
|
This version is better at flagging exceptions in event handlers so some bugs may crawl to the surface |
|
Also worth looking at is replacing the ExecutorEventEmitter with the AsyncIOEventEmitter, reducing the thread count of core somewhat. |
|
Yeah cool, I've added an internal ticket to take a look at that sometime |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pyee has added ThreadExecutor variant of the EventEmitter which can
replace the home-spun threadpool based emitter.
Adapt has been updated to match this change.
How to test
Make sure mycroft-core still works as expected.
Contributor license agreement signed?
CLA [ Yes ]