Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

upgrade Lingua Franca to 0.2.1 #2512

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

ChanceNCounter
Copy link
Contributor

@ChanceNCounter ChanceNCounter commented Mar 25, 2020

Apparently the VSCode PR extension doesn't want to edit the template before creating a PR.

Upgrades Lingua Franca. Release notes at that repo. I have mixed feelings about this PR.

On the one hand, this release fixes critical flaws in extract_number(). On the other hand, there is another PR pending at Lingua Franca which would solve other, less critical, but equally frustrating issues with the same parser. At Ake's discretion, that PR could turn directly into a 0.2.2 release, putting a bow on the problem.

Contributor license agreement signed?

CLA [ Yes ] (Whether you have signed a CLA - Contributor Licensing Agreement

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Mar 25, 2020
@forslund
Copy link
Collaborator

Let's merge this now and we'll see if we bump lingua franca another point this weekend.

@forslund forslund merged commit a77e53f into MycroftAI:dev Mar 26, 2020
@ChanceNCounter ChanceNCounter deleted the upgrade-lingua-franca-0.2.1 branch March 26, 2020 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants