Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Add resource lock tests in Jenkinsfile #2522

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

forslund
Copy link
Collaborator

@forslund forslund commented Mar 30, 2020

Description

Add a lock for the pipeline, different branches were able to run on top of each-other since each branch/pr gets a separate "job"

This lock is global across the pipeline and will force all branches to wait for the Lock to be free.

Things that needs this lock seems to be

  • identity file (multiple jobs may overwrite the identity in an incorrect way)
  • allure data

The allure data could possibly be handled without the lock by creating a temporary directory for each run.

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Mar 30, 2020
@forslund forslund force-pushed the bugfix/Jenkins-file-branch-lock branch from bab5364 to 5f71d32 Compare March 30, 2020 16:17
@forslund forslund changed the title Add branch for tests Add resource lock tests Mar 31, 2020
@forslund forslund changed the title Add resource lock tests Add resource lock tests in Jenkinsfile Mar 31, 2020
@forslund forslund merged commit f01b61e into dev Apr 2, 2020
@forslund forslund deleted the bugfix/Jenkins-file-branch-lock branch April 2, 2020 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants