This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Fallback to internal version if no version file exists #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow non-packaged versions of mycroft core to report version to the backend.
devs-mycroft
added
the
CLA: Yes
Also minor cleaning up of test code
chrisveilleux
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will allow non-packaged versions of mycroft core to report version to the backend. Resolves #2527.
How to test
Start up mycroft-skills from a desktop install go to the device section on home.mycroft.ai and check that the correct version is run.
Contributor license agreement signed?
CLA [ Yes ]