This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Feature/mic_config - Add configuration option for microphone settings #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
suggested changes
Apr 14, 2020
mycroft/client/speech/mic.py
Outdated
| @@ -199,11 +201,13 @@ class ResponsiveRecognizer(speech_recognition.Recognizer): | |||
|
|
|||
| # The maximum seconds a phrase can be recorded, | |||
| # provided there is noise the entire time | |||
| RECORDING_TIMEOUT = 10.0 | |||
| RECORDING_TIMEOUT = MIC_CONFIG.get( | |||
| 'microphone', {}).get('recording_timeout') | |||
There was a problem hiding this comment.
In python code style capital letters indicate constants, since these are no longer constants maybe we should make them lowercase object member and set them in __init__()?
self.recording_timeout = config['recording_timeout']
There was a problem hiding this comment.
moved in newer commit to class init and followed code style of existing properties
|
Voight Kampff Integration Test Succeeded (Results) |
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
listener->recording_timeout: Maximum length of recording listener->recording_timeout: Maximum length of silence before stopping recording
forslund
force-pushed
the
feature/mic_config
branch
from
2b39d1c
to
c5c0881
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a configuration option to set a custom timeout for microphone settings
How to test
Set configuration in USER / SYSTEM level mycroft.conf file to override default values
Contributor license agreement signed?
CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement